Register With OpenID disabled when providing RpxNowApiKey -

Register With OpenID disabled when providing RpxNowApiKey

This is the place to report bugs and get support. When posting in this forum, please always provide as much detail as possible.

Please do not report problems with a custom build or custom code in this forum. If you are producing your own build from the source code and have problems or questions, ask in the developer forum, do not report it as a bug.

This is the place to report bugs and get support

When posting in this forum, please try to provide as many relevant details as possible. Particularly the following:

What operating system were you running when the bug appeared?
What database platform is your site using?
What version of mojoPortal are you running?
What version of .NET do you use?
What steps are necessary to reproduce the issue? Compare expected results vs actual results.

This thread is closed to new posts. You must sign in to post in the forums.

8/6/2013 5:45:19 PM

khaled

Total Posts 8

View Posts

Register With OpenID disabled when providing RpxNowApiKey

Hi Joe ,,,

I think there is wrong "IF" statement in "RegisterLink WebControl" .

If we disable database authentication the control will check if we disabled OpenId authentication then it will use "Windows Live Authentication", otherwise it will check if we not set the "RpxNowApiKey" value then it will use "OpenId" which is wrong, it should use OpenId if there any value in "RpxNowApiKey" .

Wrong check code :

if ((!siteSettings.AllowWindowsLiveAuth) && (siteSettings.RpxNowApiKey.Length == 0))
{
urlToUse = siteRoot + "/Secure/RegisterWithOpenID.aspx";
}

Correct check code :

if ((!siteSettings.AllowWindowsLiveAuth) && (siteSettings.RpxNowApiKey.Length != 0))
{
urlToUse = siteRoot + "/Secure/RegisterWithOpenID.aspx";
}

The short story is, we have wrong "IF" statement, we should use OpneId when there is "RpxNowApiKey" value .

I hope i explain it well, sorry for the poor language, I,m not native English speaker.

8/7/2013 12:04:59 PM

Joe Audette

Total Posts 18439

View Posts

Re: Register With OpenID disabled when providing RpxNowApiKey

Hi,

The code looks correct as it is to me.

Open Id in this context is not the same thing as rpx/janrain. OpenId in this case refers to a legacy open id implementation that used that url.

rpx/janrain does not use that url "/Secure/RegisterWithOpenID.aspx", it just uses the normal register and login pages.

And when rpx/janrain is enabled then we would not want to show the legacy opein id link

Hope that helps,

Joe

You must sign in to post in the forums. This thread is closed to new posts.