ModuleTitleControl handling of EditUrl params on Initialize

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

Please do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.

This forum is for discussing mojoPortal development

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

You can monitor commits to the repository from this page. We also recommend developers to subscribe to email notifications in the developer forum as occasionally important things are announced.

Before posting questions here you might want to review the developer documentation.

Do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.
This thread is closed to new posts. You must sign in to post in the forums.
10/31/2011 2:51:05 PM
Warner
Gravatar
Total Posts 76
View Posts

ModuleTitleControl handling of EditUrl params on Initialize

Love how the Edit link adds the page and module ids automatically!

But it should do a check to see if there is already params in the Edit Url

Line:616 of ModuleTitleControl.cs

lnkModuleEdit.NavigateUrl = EditUrl
            + (EditUrl.Contains("?") ? "&" : "?")
            + "mid=" + module.ModuleId.ToInvariantString()
              + "&pageid=" + module.PageId.ToInvariantString();

 

Thoughts?

10/31/2011 3:16:47 PM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: ModuleTitleControl handling of EditUrl params on Initialize

I don't have any problem with your suggested change and will make that change if it helps you, but it isn't really expected that any other params would need to be passed there, none of the features we ship need extra params there. pageid and module id are sufficient to identify the instance and enforce security correctly. There are ways of injecting additional links if needed like in the blog we have one for draft posts.

Best,

Joe

10/31/2011 3:56:01 PM
Warner
Gravatar
Total Posts 76
View Posts

Re: ModuleTitleControl handling of EditUrl params on Initialize

It is up to you, i think it adds some flexibility to other devs,

I have modules that are, lack for a better word, "callouts" to other modules on the same/other pages.

Its just easy to code up the edit url since it is permissioned checked already to link to the page i want use to manage things.

11/7/2011 10:54:41 AM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: ModuleTitleControl handling of EditUrl params on Initialize

I implemented the change you requested, but myself I would not make modules talk to other modules on a page. In my opinion cms plugin modules should be self contained and should not depend on other cms plugin modules. They can have supporting pages but they should not depend on other modules being on the page.

Best,

Joe

11/7/2011 1:01:59 PM
Warner
Gravatar
Total Posts 76
View Posts

Re: ModuleTitleControl handling of EditUrl params on Initialize

Thanks Joe,

I would agree with the compartmentalizing modules as much as possible, but my need for flexibility in design and layout makes doing what's "right" hard, My Users are a demanding bunch that don't follow form or reason... :P

Warner~

You must sign in to post in the forums. This thread is closed to new posts.