Interested in a more accessable/stylable skin...

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

Please do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.

This forum is for discussing mojoPortal development

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

You can monitor commits to the repository from this page. We also recommend developers to subscribe to email notifications in the developer forum as occasionally important things are announced.

Before posting questions here you might want to review the developer documentation.

Do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.
This thread is closed to new posts. You must sign in to post in the forums.
9/11/2005 9:34:44 AM
Gravatar
Total Posts 2

Interested in a more accessable/stylable skin...


I'm interested in developing a more accessable skin... or at least one that relies less on tables and presentation HTML.

I'd like to share my skin, however, there are places in the code where there are hard references to (IMO) less desirable elements. If I have some questions, is this the place to ask them?

For instance, in SiteSkin.cs, there is some logic that seems to basically say: If there is an element on the page named tdLeft, then check to see if it contains a menu. If there isn't a menu in tdLeft, then cast it to a HtmlTableCell and collapse it down to "10".

Would it be completely offensive of me to write it instead to read: If there is a tdLeft AND it also happens to be an HtmlTableCell then...

Nice code, by the way... it's good to see some open source stuff that's actually readable too.

thanks,

Scott

9/11/2005 1:04:34 PM
Gravatar
Total Posts 18444

Re: Interested in a more accessable/stylable skin...

Scott,

Are you working with the code from svn or the zip file from the last release?

If you'd like to get involved with improving the skinning you will need to work from svn and send me patch files of your changes. I'll apply them against a copy and see if I agree with your changes and either work with you to resolve any disagreements or apply the changes.

The release that just went out (and the newest svn code) has major improvements but I'm sure we can do more to improve it. The main thing is not to make changes that break other skins or if you do make changes that break other skins fix the other skins to work with the changes.

You may also want to coordinate with Jasmin Savard as he has been doing a lot of work to improve the skinning.

I agree that table cell code you refer to is not the most elegant solution. The problem that it is trying to solve is that if the menu is used in the left pane a fixed width is enforced. If the menu is not there and the left pane contains no modules then I want to collapse it so the center pane can expand to take up that space. I'm certainly open to a better solution.

Thanks,

Joe
9/11/2005 9:41:02 PM
Gravatar
Total Posts 2

Re: Interested in a more accessable/stylable skin...

Thanks for the reply... I am working from the svn files. I can tell there has been a lot of work done from the differences in the release copy that I was using.

I agree that the skinning should continue to be backwards compatible. Does Jasmin read the forums, or is there another way that I should contact him if I have some questions?

In the very least, I'll have something to show you in a couple of weeks that. Then you guys can see if you're interested.

Again, thanks.

Scott
9/12/2005 2:49:55 PM
Gravatar
Total Posts 18444

Re: Interested in a more accessable/stylable skin...

He usually does read the forums but you can also reach him at jsavard at skrypt-web dot com.

~Joe
You must sign in to post in the forums. This thread is closed to new posts.