Theme.Skin controls for SlidePanel

This is a forum to suggest new features for mojoPortal. 

This thread is closed to new posts. You must sign in to post in the forums.
8/22/2013 7:33:30 PM
Gravatar
Total Posts 88

mojoPortal Hosting & Design @ i7MEDIA!

Theme.Skin controls for SlidePanel

Joe,

There are a few pet projects of mine that would benefit being able to render content only type settings like the OuterWrapperPanel settings, something like this:

<portal:SlidePanel runat="server"
    RenderContentsOnly="true"
    RenderId="false"
    />

I was playing around in my local development installation and got it working but changing the SlidePanel public class to pull from BasePanel instead of Panel, but I'm sure that would probably break things that I am unaware of.

Anyways, if you could do that it would be cool, but it's not important.

Thanks,
-Elijah

 

8/23/2013 11:41:11 AM
Gravatar
Total Posts 18439

Re: Theme.Skin controls for SlidePanel

Hi Elijah,

I'm not philosophically opposed to making BasePanel the base class of SlidePanel, but I don't see how those 2 specific properties would benefit anything since those settings would break the SlidePanel. It would wire up its javascript but the expected div with the expected id for the jquery selector would be missing from the markup of the page with the settings as you posted.

Am I missing something? How could that have worked for you?

Best,

Joe

8/23/2013 12:17:36 PM
Gravatar
Total Posts 88

mojoPortal Hosting & Design @ i7MEDIA!

Re: Theme.Skin controls for SlidePanel

Joe,

Those two properties were used mainly for example, reducing markup like that would only be advantageous when working on a mobile skin and for more strict HTML5 markup, which is what I was testing at the time. Also a general rule I don't use the Cycle slider for my projects because it's non-responsive, so removing the ID and DIV itself wouldn't hurt my projects.   Setting classes or adding top/bottom content along with the other settings would be handy along with the other uses I mentioned earlier though.

Another thought I had, would it be possible optionally place the module anchor inside the moduletitle?

Best,
-Elijah

8/29/2013 12:30:48 PM
Gravatar
Total Posts 18439

Re: Theme.Skin controls for SlidePanel

Hi Elijah,

I've changed the base class as you requested in the source code repository.

The module anchor is another topic. It got me thinking whether it should go in the beginning or end of the heading, or maybe wrap it  or the inner text (but that would likely/definitely affect style in most existing designs).

But after more thought, since it is a destination anchor not a linking anchor I think we can do away with it's "a" tag completely and just render the id on the heading element directly, any anchor that links to it should still work. The only time we would still need the anchor is if "ShowTitle" is false.

Best,

Joe

8/29/2013 12:41:12 PM
Gravatar
Total Posts 88

mojoPortal Hosting & Design @ i7MEDIA!

Re: Theme.Skin controls for SlidePanel

That's awesome.  I like what you did with the module anchor, it makes more sense that way.

Thanks for the good work,
-Elijah

You must sign in to post in the forums. This thread is closed to new posts.