Hi,

I suppose what you are calling a bug is that the extra AddedCrumbs are not inside the span that wraps the other crumbs.

Unfortunately there is nothing I can do about that, under the hood we are using a SiteMapPath control which is databound to the SiteMap and the added crumbs is just literal extra markup that we can inject after the markup generated by the SiteMapPath control, we don't have a way to get inside there.

My advice is just don't use those spans for styling then they will not affect anything. Apply styling only at the outer div and on the links and pretend those spans are not even there.  

Hope that helps,

Joe

Hi Guys,

I just looked into it further and I did find way to eliminate the outermost span. With the outermost span removed then you could add spans around your additional crumbs and they will be the same as other crumbs.

BreadcrumbsControl breadcrumbs = (BreadcrumbsControl)Master.FindControl("Breadcrumbs");
breadcrumbs.AddedCrumbs = "<span><a class="selectedcrumb" href="/Product-Details.aspx">Product Details</a></span>";

Then you could use the spans for styling if you wanted to.

I think I could possibly eliminate all the spans if I implement a custom SiteMapNodeItem control and use it instead of the default one. But then you would also not be able to use them for styling.

Which solution do you think would be preferable?

1. Just remove the outer span so you can then use spans on your added crumbs and then you could use the spans for styling
2. Eliminate all the spans and just have links inside the out div

Basically the general problem and solution is described in this blog post. Many controls render spans but it is possible to get rid of them if you create a custom control that inherits from the original control, and then you override the Render event and just change it from base.Render(HtmlWriter); to base.RenderContents(htmlWriter); it then leaves out the span that would be the outer markup.

I removed the outmost span by doing this on our mojoSiteMapPath control. To get rid of the rest of them I would need to implement a custom SiteMapNodeItem control.

Best,

Joe

Hi Tarek,

Sorry but I do not have a solution for that. We are just injecting some extra crumbs after what is rendered by the SiteMapPath control. It adds that selectedcrumb class because the current page is the active page based on the page id. There is not any easy way to change that after it has already been rendered and it is correct for the context of the CMS page involved.

What I've decided is to make it possible to render with or without the spans but the default will be without them since I think probably most people are not using those spans to style the links, but if someone reports a problem I can tell them how to restore the previous behavior by adding this to the theme.skin file:

<portal:SiteMapPath runat="server"
  RenderContentsOnly="false"
/>

<portal:mojoSiteMapNodeItem runat="server"
  RenderContentsOnly="false"
/>

So the first one controls whether that outer span is rendered and the second one determines if spans are created around the links and the path separators.

So the problem will remain that if you rely on that outer span then additional crumbs will not be inside it. Therefore the only useful choices are to leave out the outer one and then add spans on the added crumbs or to leave out all the spans and just use the div and the links to apply style. This last approach seems best to me since you and I don't have control over custom features developed by others that may add links to the crumbs so you cannot expect that they will always have spans. So historically those spans were not useful for styling anyway if there are extra crumbs added that did not include them.

Sorry I don't have a perfect solution but this is the best I can come up with at the moment.

Best,

Joe