Different messages for different password change failure reasons

This is a forum to suggest new features for mojoPortal. 

This thread is closed to new posts. You must sign in to post in the forums.
4/25/2007 12:34:41 PM
Alexander V. Yushchenko
Gravatar
Total Posts 488
View Posts

Different messages for different password change failure reasons

On change password page, the same message appears for any failure reason (old password incorrect, new passwords does not match, new password too short, etc).

It would be much more user-friendly to display different messages in these cases.

4/25/2007 1:52:54 PM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: Different messages for different password change failure reasons

In svn I've improved this so it gives good messages about not matching or required fields empty.

Still looking into how to show messages about password too short or failure against password regex expression. Password changes fail from the memebrship provider in these cases but it does not report back the reason.

Thanks,

Joe

4/25/2007 4:01:21 PM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: Different messages for different password change failure reasons

I implemented a custom validator. It now shows good error messages for Min Password Length, MinNonAlphaNumeric chars, and if current password entered isn't correct.

If it fails the RegularExpression it gives a message "Password isn't strong enough".  Not a perfect solution but no real way to know what the rules are from the expression. Maybe in the future we can have the error come from site settings instead of from resource file.

Thanks,

Joe

4/26/2007 4:16:15 AM
Alexander V. Yushchenko
Gravatar
Total Posts 488
View Posts

Re: Different messages for different password change failure reasons

Thanks for the improvement!

Just some minor comments:

1. If the new password is identical to the old one, it is still "changed". Is there any way to catch this situation and display another message?

2. It would be nice to use another localized message for "old password required" because on this page it is "old password", but on the registration one it is just "password", so it's not the same.

4/26/2007 6:54:10 AM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: Different messages for different password change failure reasons

both of these are now done in svn. Good suggestions.

Thanks,

Joe

5/3/2007 7:51:59 AM
Alexander V. Yushchenko
Gravatar
Total Posts 488
View Posts

Re: Different messages for different password change failure reasons

Some more on localizable messages.

1. All the new messages start with "ChangePassword", but also 2 old ones are used: "UserNewPasswordRequired" and "UserChangePasswordFailureText". This violates the naming convention. It would be nice to rename them.

2. The message defined by UserChangePasswordFailureText should be changed as all the common reasons of the failure are checked separately.

3. "RegisterConfirmPasswordRequiredMessage" key is still used on "change password" page instead of a separate one.

5/3/2007 11:03:35 AM
Alexander V. Yushchenko
Gravatar
Total Posts 488
View Posts

Re: Different messages for different password change failure reasons

Thanks for the improvement!

One little notice: you renamed all the old keys but one: UserChangePasswordLabel. Did you just forget it?

5/3/2007 11:42:52 AM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: Different messages for different password change failure reasons

That is used on UserProfile.aspx to link to the Change Password page.

Joe

5/3/2007 11:53:40 AM
Alexander V. Yushchenko
Gravatar
Total Posts 488
View Posts

Re: Different messages for different password change failure reasons

Yes.

But it is also used on ChangePassword.aspx

May be, it is better to create a separate key?

5/3/2007 12:43:51 PM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: Different messages for different password change failure reasons

Ok, I missed the one in the ChangePassword.aspx file and only got the code behind. I'll fix it.

Thanks,

Joe

5/4/2007 5:34:51 AM
Alexander V. Yushchenko
Gravatar
Total Posts 488
View Posts

Re: Different messages for different password change failure reasons

Thanks, now it's perfect.

You must sign in to post in the forums. This thread is closed to new posts.