Help with Forum ThreadSubID and ForumSubID in the Subscribers dataset

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

Please do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.

This forum is for discussing mojoPortal development

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

You can monitor commits to the repository from this page. We also recommend developers to subscribe to email notifications in the developer forum as occasionally important things are announced.

Before posting questions here you might want to review the developer documentation.

Do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.
This thread is closed to new posts. You must sign in to post in the forums.
12/15/2010 3:29:39 PM
Gravatar
Total Posts 15

Help with Forum ThreadSubID and ForumSubID in the Subscribers dataset

Hi there,

I'm pretty sure I updated my development code to the latest code from the repository but I'm having a problem when I'm testing the forums and wonder if something is mismatched.  In mojoPortal.net\Notification.cs, there is some code in SendForumNotificationEmail that references a dataset with columns ThreadSubID and ForumSubID.  I've scanned the code and also the stored procedures and am not able to locate where these are set.  I went to CodePlex to check the latest code there and browsed the SchemaInstallScripts for the forums and can't find anything that returns these columns.  I used VSS (2010) to try to search for where they might be set in the entire solution and still can't find it!  Can anyone point me in the right direction?  I am getting an error when I submit a post and the error is complaining that ThreadSubID does not exist.

Thanks,

Thao

 

12/15/2010 4:02:51 PM
Gravatar
Total Posts 1203
Proud member of the mojoPortal team

Help support mojoPortal!
Add-on modules

Re: Help with Forum ThreadSubID and ForumSubID in the Subscribers dataset

Hi, in the Notification.cs source file, the comment above the class Notification says:

/// this class is deprecated, better to create an EmailMessageTask messageTask = new EmailMessageTask(SiteUtils.GetSmtpSettings());

So this class isn't used any longer in mojoPortal, and as the comment says, I wouldn't recommend trying to use this class for any development.

Jamie

12/15/2010 5:56:30 PM
Gravatar
Total Posts 15

Re: Help with Forum ThreadSubID and ForumSubID in the Subscribers dataset

Hi Jamie, thanks for pointing that out to me, it also showed me that I do NOT have the latest code in my development environment because I was trying to trace that class and never saw that comment, but I see that comment in the CodePlex version of the file.  OK, guess I better clean up my development environment and get things up-to-date.

Thanks for the quick reply!

 

12/15/2010 6:28:19 PM
Gravatar
Total Posts 1203
Proud member of the mojoPortal team

Help support mojoPortal!
Add-on modules

Re: Help with Forum ThreadSubID and ForumSubID in the Subscribers dataset

Absolutely. I'm glad to help. I actually try to use TortoiseHG to pull the latest changes into my development tree every week or so, and always right before I get down to work on any custom features. It's not too difficult to do--I just have to make some simple decisions for merging web.config occasionally.

Joe Audette makes changes to the source code almost every business day, so it's definitely worth staying as up-to-date as possible.

Jamie

12/15/2010 7:33:32 PM
Gravatar
Total Posts 15

Re: Help with Forum ThreadSubID and ForumSubID in the Subscribers dataset

Hi Jamie, just curious.  I actually started a custom forum module a few months ago so I based it on a version way back then.  I pulled Joe's code to my development machine a couple of weeks ago and so I'm sure my custom forum doesn't contain the latest changes his forum has.  I'm not an expert at this, so once I've already made my custom component, I don't fold in any of his later changes because I've already tested all my code and fear breaking it somewhere with no time to fix it for a deadline, but do you tend to do this -- check the change logs and somehow merge his changes back into your custom module?  I don't think I have a great process in place but our deadlines are tight and it's great to hear how others manage this aspect.

12/16/2010 6:24:01 AM
Gravatar
Total Posts 18439

Re: Help with Forum ThreadSubID and ForumSubID in the Subscribers dataset

If you're modifying the forums feature to customize it you should clone it, and only modify your custom copy and it should use its own tables not the same tables as the included feature.

Going forward with a clone you would have to manually copy and paste changes I make to the official forums feature if you want to, but if you just modify it directly then you are making it difficult for yourself to upgrade without losing your customizations. The whole idea is to keep all your custom code in your own projects and then it is much easier to pull the latest mojo code and merge it. Once you make changes to mojo code then you are stuck maintaining your modified version and have a more difficult task to merge the rest of mojoportal and you can never use official release packages but always have to make your own custom build. 

If you go down that path of making changes directly to mojo code it is scary to get the latest changes, if you stay on the recommended path and keep your custom code separate it is easy and nothing to be afraid of.

Hope it helps,

Joe

12/16/2010 11:38:41 AM
Gravatar
Total Posts 15

Re: Help with Forum ThreadSubID and ForumSubID in the Subscribers dataset

Hi Joe, thanks, and yes, I do clone your modules.  What I do is test my module at the same time I test your module, so I can compare the functionality in order to try to determine if a bug in my code might be happening in your code (and of course, I've never run into your code being buggy when my code was buggy!)  I think this is the first time that I hit a problem in my cloned copy that I couldn't figure out what was going on, so I went to your forum module to trace it to see where I might've done something wrong in my copy, and then I ran into this problem with the ThreadSubID and ForumSubID error.  So both my cloned forum and the forum I have from mojo experiences this bug, but I really need to go through it a lot more closely and make sure I have the latest code.  I am now in the process of the manual copy and paste you mentioned, hopefully, I'll get down to the bottom of this in my cloned version.

thanks!

Thao

 

 

12/16/2010 11:42:50 AM
Gravatar
Total Posts 15

Re: Help with Forum ThreadSubID and ForumSubID in the Subscribers dataset

Forgot to mention, I also have all my own copies of the tables and stored procedures as well, everything gets cloned, I thought the training documentation and video tutorials were very helpful and made this part pretty easy.

You must sign in to post in the forums. This thread is closed to new posts.