Thanks for the work done, I just finished this in a patch I sent you today.

As I can see, you did not apply part of my patch where I excluded "ForumNotificationEmailSubject" and "ForumPostReplyPrefix" from resources.

Let me explain why did I do that.

I agree that these strings can be localized in some way. But I disagree with the way it is being done now. The problem is that when one replies to forum thread, this strings are taken for the one's locale, but shown to other people!

For example, what happens if these strings are localized to french and someone with french browser settings replies to this post? I will recieve e-mail notification with subject written in french and see the title written in french. But I don't understand that language!

Now this does not happen because thiese strings are not localized. But if they do, we will have the problems described.

So, my opinion is:

1. Now it can be web.config properties, site settings, forum module settings - everything, but not localizable resources.

2. "ForumNotificationEmailSubject" can potentially be localized, but in this case we should have some profile property like "prefered language" and determine the locale from it instead of the way it is determined now.

Thanks, I agree with this solution.

P.S. StopRefreshImage is somehow back to resources.

UPDATE: thanks for removing this.