Hi Rick,

I don't have any problem with adding that setter as it is similar to the one for moduleid, I will add it, but I think the implementation of your own feature is problematic and I would advise against it. The problem is you are databinding a grid and in the itemdatabound event of each row you are making another call to the db by using this constructor on module which is not a good idea at all and won't scale well. 

Its fine to use UserControls but SiteModule is a special UserControl designed for a much different purpose than what you are doing. 

Best,

Joe 

Hi Joe

Thanks for the advice.  I can see the performance issue when I run this through debug.  On a going forward basis I'll not use SiteModule for my custom user controls.  however...  I'm going to leave in this quick fix till I get time to fix it up.  I've got to demo this feature to my manager tomorrow AM and time is running out.

Thanks

Hi Rick,

I would broaden my advice to don't use any UserControl in a grid if that UserControl makes any database hits. It basically an architectural and performance anti pattern. I mean it can be ok like inside an EditItemTemplate of an editable grid but not an ItemTemplate, because when editing its just the active row where the extra db access will occur. Its particularly bad if the grid is binding to an IDataReader because it has an open connection with the db while it databinds and if more things are making data requests you are using multiple connections at once.

You should generally design it so that all the data needed by the grid is in the result set. If its a situation where you need a master/detail kind of grid you can create a DataSet with multiple data tables in it connected by datarelations. One place in mojoportal code where you can see an example of constructing such a DataSet is in the WebStore.Business project in the Store.cs line 565 GetProductPageWithOffers.

I would not use a Grid to layout feature rich controls that do internal data access.

Hope it helps,

Joe