“Good news everyone!”: Applying file modifications; XHTML validity

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

Please do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.

This forum is for discussing mojoPortal development

This forum is only for questions or discussions about working with the mojoPortal source code in Visual Studio, obtaining the source code from the repository, developing custom features, etc. If your question is not along these lines this is not the right forum. Please try to post your question in the appropriate forum.

You can monitor commits to the repository from this page. We also recommend developers to subscribe to email notifications in the developer forum as occasionally important things are announced.

Before posting questions here you might want to review the developer documentation.

Do not post questions about design, CSS, or skinning here. Use the Help With Skins Forum for those questions.
This thread is closed to new posts. You must sign in to post in the forums.
2/11/2006 12:57:30 AM
Gravatar
Total Posts 23

Re: Good news everyone!: Applying file modifications; XHTML validity

My effort to make mp W3 XHTML 1.1 compliant yield fruit. I've made several changes to several files and reduced hereby the number of XHTML errors by about a dozen. Furthermore I've created a new layout, which structure is totally based on div elements (an alpha version can be viewed on my website) and don't have any tables. The CSS file, the layout is based on, is already 100% W3C valid. The modifications in *.ascx.cs files don't influence the structure/appearance of already existing layouts but make them more W3C compliant.

I have no commit access to the svn repository. How can I apply the changes to the trunk src repository?

Since XHTML 1.0 there is no target attribute in links because it's redundant. In fact it's an user affair (browser preferences) to specify where new windows/tabs should be opened and shouldn't be a static determination (that nevertheless can be overridden by user command/preferences) by developers.

Also the width/height of imgs should be specified explicitly and the alt attribute in imgs is compulsory.
2/11/2006 3:54:53 AM
Gravatar
Total Posts 148

Re: “Good news everyone!”: Applying file modifications; XHTML validity

Thanks for working on this!  entity.blogdns.net is not responding at the moment, but what you describe sounds very nice.  Please send your patches (output of 'svn diff') to me (dean at brettle dot com).   Assuming they look OK and Joe doesn't object, I'll apply the patches to the trunk and commit sometime in the near future.  Note however that when Joe's similar work in the 2.1 branch gets merged into the trunk, there is a good chance we will just opt to copy over your changes, since attempting to merge would probably be more trouble than it's worth.  That said, I think we should compare the 2 approaches to see if there are any benefits to be gained from some sort of hybrid.

--Dean
2/11/2006 4:18:58 AM
Gravatar
Total Posts 18444

Re: “Good news everyone!”: Applying file modifications; XHTML validity

Good deal! I have no objections at all. Dean I appreciate your willingness to work with Alexander on getting the patches in. I suspect I am doing similar work in 2.1 but I will review the 1.0 branch once his changes are in and make sure I'm not missing anything in my work.

I'm going through all the modules and pages. Right now I have a lot of changes I haven't committed because I don't want to commit until all the skins look right with the changes, but hopefuly I will get to a point this wekend where I can commit my changes on the 2.1 branch. So far I've converted one skin to css layout and a number of the modules but still a little ways to go and then I have to go back and fix the other skins.
You must sign in to post in the forums. This thread is closed to new posts.