Hi Joe,

The ckEditor toolbar configuration in 2.3.9.6 leaves out some rather common items:

• 'Outdent', 'Indent' (used to set the depth of lists or to indent a paragraph)
• ['JustifyLeft', 'JustifyCenter', 'JustifyRight', 'JustifyBlock']
• 'Subscript', 'Superscript'

One that I think would be useful but we haven't included in the past is 'ShowBlocks'. It outlines all of the block elements (p, div).

I know we can setup our own config for these toolbars but I hoping you would see the value of the above items and add them back to the default.

Thanks,
Joe

Hey Joe,

I could put those back or you can override them but do we really want those things or should they come from CSS?

ie do we really want to do things like this in the editor content:

<p style="text-align: justify;">

or indent:

<p style="padding-left: 30px;">

?

I feel kind of the same way about those as the fonts and colors and why they are removed from the editor because hard coded style goes against skinnable design where everything should be controlled by CSS.

Thanks for the heads up about the extra commas, I'll fix that.

Best,

Joe

Hi Joe,

I didn't see your response from the 24th. I agree with your points there.

Including these in a common CSS file and then overriding the buttons sounds like a great idea to me.

I just tried using the config.justifyClasses option and it works well.

I'll look into the Indent and Superscript/Subscript.

Thanks,
Joe D.

Thanks for the help with this. The source code repository has been updated with the latest version of CKeditor as well as the css classes and config changes to support indents and justify from css.

Unfortunately there doesn't seem to be corresponding config options for TinyMCE so it still uses hard coded styles.

Best,

Joe

What steps did you use to get the source code? The only correct way to get the source code is with TortoiseHG.

Are you sure you are using source code not the pre-compiled official release? 

Are you sure you applied the changesets to your working copy?

Did you rebuild the solution and visit /Setup/Default.aspx?

Does the style.config file in your skin include the common css?

<file cssvpath="/Data/style/common/style.css" imagebasevpath="/Data/style/common/">none</file>

The demo site is not yet updated with these changes.

See Important Skin Changes for notes about updating your skin. 

You may need to reset your skin guid and do a hard refresh to make things look right in the editor after making changes to skin such as style.config

Hope that helps,

Joe

Hi Don,

Just did a quick test here locally and I found it was not working correctly in the editor in Artisteer skins because of this which needs to be removed from style-artisteroverrides.css

body.wysiwygeditor  p
{
  font-size: 14px;
  margin: 12px 0;

}

So it was overriding the indent class. another solution would be to move the reference to the common css lower in the stlye.config file than that artisteer css files to give it more precedence but probably removing that is the best solution.

Hope that helps,

Joe