Is there any way to remove jPlayer from appearing in the WebStore?

If you have questions about using mojoPortal, you can post them here.

You may want to first review our site administration documentation to see if your question is answered there.

This thread is closed to new posts. You must sign in to post in the forums.
8/31/2012 9:54:51 AM
Adobe Wan Kenobi
Gravatar
Total Posts 22
View Posts

Is there any way to remove jPlayer from appearing in the WebStore?

I had implemented jPlayer on my site before it was integrated into MojoPortal.

I designed a custom skin that looks/runs better than either of the default jPlayer skins.

I want to include that html/css in each product, but the automatic/default jPlayer instance that is included after every offer is broken, looks terrible because of splattered/broken CSS, and doesn't even list or play the items it's supposedly connected to... clicking on anything just takes you to the top of the page.

So my question is:

How do you disable the automatic inclusion of the existing jPlayer so this block of defunct code won't be polluting my offer list in the WebStore? There's no mention of jPlayer in the web.config file.

/\dobe \/\/an

8/31/2012 10:07:16 AM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: Is there any way to remove jPlayer from appearing in the WebStore?

You can remove the jplayer css from your style.config file of your skin and add your own from there.

If it isn't working it sounds like you may not even have the default jplayer skin css included in your style.config. Did you upgrade from an older version than 2.3.7.6? There are notes in the Important Skin Changes article about adding the needed css for jplayer.

It works for me locally and on the demo site and we are using the latest version of jPlayer. You can easily use your own css for jplayer.

Hope that helps,

Joe

8/31/2012 10:20:14 AM
Adobe Wan Kenobi
Gravatar
Total Posts 22
View Posts

Re: Is there any way to remove jPlayer from appearing in the WebStore?

Created a fix...

  1. Created a duplicate of the bluemonday style folder for jPlayer (~/Data/style/jplayer/bluemonday)
  2. Renamed this folder bluemonday.noshow (~/Data/style/jplayer/bluemonday.noshow)
  3. Renamed the CSS file to jplayer.blue.monday.noshow.css
    (~/Data/style/jplayer/bluemonday.noshow/jplayer.blue.monday.noshow.css)
  4. Added "display: none;" to the style for div.jp-audio (lines 26-42) in the CSS
  5. Added stylesheet link in the offer list control (~/WebStore/Controls/OfferListControl.ascx) before line 4 to override default
8/31/2012 10:24:59 AM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: Is there any way to remove jPlayer from appearing in the WebStore?

You should not modify the .ascx file that is forking the code and creates a maintenance problem for you and is not the correct place to add css since css should be in the head.

You can add or remove css files from style.config

8/31/2012 10:25:23 AM
Adobe Wan Kenobi
Gravatar
Total Posts 22
View Posts

Re: Is there any way to remove jPlayer from appearing in the WebStore?

Thanks for the reply, Joe!

I created a custom skin/CSS for the jPlayer; however, it required rearranging the default button layout for the player (mine has the volume control before playback). The code for which order the html elements are displayed seem to be compiled into the .dll for the control. (Maybe put the actual html code layout into the OfferListControl.ascx so people can edit it?)

All things aside, the default bluemonday skin fails, and there are no links to the associated products in the offer list, and clicking on anything just takes you to the top of the page. The CSS seems broken, as well.

If you want, I can give you the new skin I made so you can see what I've done.

Thanks again,

/\dobe \/\/an

8/31/2012 10:27:40 AM
Adobe Wan Kenobi
Gravatar
Total Posts 22
View Posts

Re: Is there any way to remove jPlayer from appearing in the WebStore?

I had to add the CSS link in the .ascx file because the CSS file I link to in the style.config is being used elsewhere on the site. I don't want a global disable, just on the offer listing since the jPlayer there is broken.

8/31/2012 10:28:59 AM
Adobe Wan Kenobi
Gravatar
Total Posts 22
View Posts

Re: Is there any way to remove jPlayer from appearing in the WebStore?

BTW, my jPlayer skin is for v2.1.0, the version you've included in MojoPortal v2.3.9.0

8/31/2012 10:36:40 AM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: Is there any way to remove jPlayer from appearing in the WebStore?

OfferListControl is not meant to be edited, that is forking the code. The jplayer markup used there comes from Web/Controls/jPlayerPanel.cs but this also should not be modified and I don't really have a way for you to easily change that markup without forking it.

However, you could submit a patch to the jPlayerPanel control that adds a property like PlaceVolumeBeforePlayback then have an if statement to render the alternative markup if that is true. The property could then be set from theme.skin.

jPlayer is not broken in my copy so first you should figure out what is breaking it in yours, use browser tools and look for script errors.

BlueMonday is used on the demo site and is working in the webstore demo there.

8/31/2012 10:40:12 AM
Joe Audette
Gravatar
Total Posts 18439
View Posts

Re: Is there any way to remove jPlayer from appearing in the WebStore?

You should not add css in the .ascx file

most features have extra css classes you can already use like:

.webstore div.jp-audio { display:none; } which will override it only in webstore

8/31/2012 10:40:44 AM
Adobe Wan Kenobi
Gravatar
Total Posts 22
View Posts

Re: Is there any way to remove jPlayer from appearing in the WebStore?

Actually, the jPlayer on the demo sites is slightly broken as well. (The "previous track" button is BEHIND the play position indicator.)

My jPlayer still doesn't link to any files (no file listing in the jPlayer below each offer) and the layout is different than appears on the demo site. (On mine, the volume min/max buttons are behind and below the play position indicator, and the back/next buttons are falling off the div below the volume indicator.)

All of my WebStore items were added in MojoPortal version 2.3.4.3 MSSQL. 

8/31/2012 10:59:52 AM
Adobe Wan Kenobi
Gravatar
Total Posts 22
View Posts

Re: Is there any way to remove jPlayer from appearing in the WebStore?

The links and click functionality are working now... can't explain why they weren't before, but I have a fix for the CSS to make the jPlayer look correct on your demo sites, which should be running MojoPortal v2.3.9.0 with jPlayer v2.1.0.

Go to jplayer.blue.monday.css

Change line 323 (in div.jp-audio div.jp-volume-bar) to read:

left:270px;

And change lines 262 and 267 (in div.jp-audio div.jp-type-single a.jp-mute, div.jp-audio div.jp-type-single a.jp-unmute and div.jp-audio div.jp-type-playlist a.jp-mute, div.jp-audio div.jp-type-playlist a.jp-unmute) to read:

margin-left: 225px

Hope this helps.
Cheers!

/\dobe \/\/an

You must sign in to post in the forums. This thread is closed to new posts.