Hello Joe,

I think that dbPortal class is quite huge and there is a lot of chances to create hidden bugs. I think it is a problem mostly in parameter definitions.

So I have created a supporting class, which gives me the possibility to write code like this:

public static IDataReader SharedFile_GetSharedFilesByPage(int SiteID, int PageID)
{
    SqlParameterHelper sph = new SqlParameterHelper(GetConnectionString(), "mp_SharedFiles_SelectByPage", 2);
    sph.DefineSqlParameter("@SiteID", SqlDbType.Int, ParameterDirection.Input, SiteID);
    sph.DefineSqlParameter("@PageID", SqlDbType.Int, ParameterDirection.Input, PageID);
    return sph.ExecuteReader();
}

You can see that code is much more smaller. I have also added some asserts into new class, so it is providing basic checks for parameter names, types and directions (when using cached parameters).

Result of this change is decrease of code lines from 13000 to 4600.

Are you interested in such a change? I have changed already my MSSQL dbPortal (latest version).

Petr Kures