Version control limits

This is a forum to suggest new features for mojoPortal. 

This thread is closed to new posts. You must sign in to post in the forums.
4/15/2012 10:47:05 PM
Gravatar
Total Posts 2162

Version control limits

Hey Joe,

So the too many form elements issue pops up with the html content versions panel. I have a client who has over 120 previous versions on one feature instance. I think if we had a button to delete versions older than X days or if we had a config setting to auto-delete versions older than X days. The auto-delete action could fire when a new version is created.

Thanks,
Joe D.

4/16/2012 3:25:12 PM
Gravatar
Total Posts 18439

Re: Version control limits

Hey Joe,

Couldn't you just set a smaller page size for version history in the html feature settings to reduce the number of controls? The default is 10 and that should not cause any problem no matter hw many versions there are in history.

Best,

Joe

4/16/2012 3:44:45 PM
Gravatar
Total Posts 2162

Re: Version control limits

It's set to 10 but the problem is there. We get the error below when we try to update the HTML content or click on one of the version history page links.

2012-04-16 15:36:05,399 ERROR (null) - (null) - (null) - mojoPortal.Web.mojoBasePage - 65.31.211.163-en-US - /HtmlEdit.aspx?mid=327&pageid=97
System.Web.HttpException (0x80004005): The URL-encoded form data is not valid. ---> System.InvalidOperationException: Operation is not valid due to the current state of the object.
   at System.Web.HttpValueCollection.FillFromEncodedBytes(Byte[] bytes, Encoding encoding)
   at System.Web.HttpRequest.FillInFormCollection()
   at System.Web.HttpRequest.FillInFormCollection()
   at System.Web.HttpRequest.get_Form()
   at System.Web.HttpRequest.get_HasForm()
   at System.Web.UI.Page.GetCollectionBasedOnMethod(Boolean dontReturnNull)
   at System.Web.UI.Page.DeterminePostBackMode()
   at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)

The only way around it at this point is to use the aspnet:MaxHttpCollectionKeys setting.

Thanks,
Joe D.

4/16/2012 3:52:23 PM
Gravatar
Total Posts 18439

Re: Version control limits

Is there anything else on the page like modules using module wrapper or something else like custom controls in the skin that may be adding to the viewstate of the page separate from the feature itself?

I created more than 10  version histories and I'm not getting any errors. It sounds like your page has a lot more viewstate for some reason.

Best,

Joe

4/16/2012 4:26:52 PM
Gravatar
Total Posts 2162

Re: Version control limits

I've only got 19 viewstate items on this page when viewing it. When I edit the content with the 120+ versions, HtmlEdit.aspx has 7000+ viewstate items. There are 5 modules on the page and a search box. The 5 modules are HTML content (3), Site Statistics (1) and Google Translate (1). One of the html modules and the Google Translate are in ModuleWrappers. The module we're having the trouble with is not in a ModuleWrapper.

Removing the ModuleWrappers from the page doesn't stop the error from occuring.

Editing any of the other html content modules on the page does not produce an error.

It seems that the version paging is adding viewstate for all of the elements on all of the pages, not just the currently selected page.

Thanks,
Joe D.

4/17/2012 7:51:17 AM
Gravatar
Total Posts 18439

Re: Version control limits

Hey Joe,

After investigating this I found that the history grid is not the major contributor to the viewstate size, it was the viewstate for CKeditor and the size is mainly caused by the size of the content in the editor itself. I've fixed this by disabling viewstate on CKeditor so this will be fixed in the new release that will hopefully ship tomorrow. For now if you change to TinyMCE I think you will find the viewstate is greatly reduced and no error will happen.

Thanks,

Joe

4/17/2012 9:59:09 AM
Gravatar
Total Posts 2162

Re: Version control limits

Awesome! I'm glad you found that. I was starting to think I had a weird install or something.

Thanks!,
Joe D.

You must sign in to post in the forums. This thread is closed to new posts.